Export Link type in Summary.tsx#429
Closed
pprev94 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hello, There are several Link types in the library, so we can’t export the one from Summary as-is without risking naming conflicts. One option would be to use a namespace and expose it as SummaryProps.Link, but that feels a bit heavy for this use case. Alternatively, we could export the type under a different name, such as SummaryLink, if you prefer having a named type. In the meantime, I recommend using Let me know what you think! |
Contributor
Author
|
You're right, Link is a too common word and can be a source of conflicts. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For convenience, export the link type from Summary.tsx